unTODO test in GH 21827 TODO tests #23722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restructures the TODO tests for GH 21827 so that the test that passes is not marked as TODO while the failing tests still are. warnings_like() had to be swapped out for capture_warnings() with manual testing so that we could have granular control over the tests, as we did not have such granular control with the three tests that were originally generated by warnings_like().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the discussion under #23701.
This PR restructures the TODO tests for GH 21827 so that the test that passes is not marked as TODO while the failing tests still are. warnings_like() had to be swapped out for capture_warnings() with manual testing so that we could have granular control over the tests, as we did not have such granular control with the three tests that were originally generated by warnings_like().